Skip to content

chore: Upgrade to Jackson 3.0.1 and remove workaround #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 24, 2025
Merged

chore: Upgrade to Jackson 3.0.1 and remove workaround #4108

merged 9 commits into from
Oct 24, 2025

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Sep 29, 2025

Artur- and others added 4 commits September 29, 2025 14:07
@Artur- @claude
Remove Jackson #5319 workaround and update to 3.0.0-rc11
b1b2288 
- Remove float-to-int coercion workaround methods from EndpointInvoker
- Remove TreeTraversingParser limitation comments and logic
- Update Jackson version from 3.0.0-rc9 to 3.0.0-rc11
- Issue #5319 is fixed in Jackson 3.0.0-rc11

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@Artur-
Merge branch 'main' into remove-jackson-workaround
a19d1c4
@Artur-
Jackson 3 is out
0d285f5
@Artur-
Merge branch 'main' into remove-jackson-workaround
af714eb
@Artur- Artur- marked this pull request as ready for review October 8, 2025 11:55
@Artur- Artur- changed the title Remove Jackson #5319 workaround and update to 3.0.0-rc11 Remove Jackson #5319 workaround and update to Jackson 3.0.0 Oct 8, 2025
@Artur- Artur- changed the title Remove Jackson #5319 workaround and update to Jackson 3.0.0 chore: Upgrade to Jackson 3.0.0 and remove workaround Oct 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.27%. Comparing base (6f7d344) to head (c3cadbd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4108   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         123      123           
  Lines        8474     8474           
  Branches     1301     1301           
=======================================
  Hits         7311     7311           
  Misses       1140     1140           
  Partials       23       23
Flag Coverage Δ
unittests 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Artur-
Copy link
Member Author

Artur- commented Oct 9, 2025

FasterXML/jackson-databind#5319 (comment)

@platosha platosha force-pushed the remove-jackson-workaround branch from 3814c40 to 45638d4 Compare October 9, 2025 10:02
@platosha
Copy link
Contributor

platosha commented Oct 9, 2025

Looks like we can't remove the workaround yet.

@Artur- Artur- changed the title chore: Upgrade to Jackson 3.0.0 and remove workaround chore: Upgrade to Jackson 3.0.1 and remove workaround Oct 12, 2025
@Artur-
Copy link
Member Author

Artur- commented Oct 12, 2025

FasterXML/jackson-databind#5340 (comment)

platosha
platosha approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are blocked waiting for the jackson 3.0.1 release though

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Artur-
❌ platosha
You have signed the CLA already but the status is still pending? Let us recheck it.

@Artur-
Copy link
Member Author

Artur- commented Oct 24, 2025

3.0.1 seems to be out now

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Artur- Artur- merged commit 2d0ed98 into main Oct 24, 2025
15 checks passed
@Artur- Artur- deleted the remove-jackson-workaround branch October 24, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@platosha platosha platosha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Artur- @platosha @CLAassistant